Checks for command string
От | Bruce Momjian |
---|---|
Тема | Checks for command string |
Дата | |
Msg-id | 200601010418.k014Imv01861@candle.pha.pa.us обсуждение исходный текст |
Ответы |
Re: Checks for command string
|
Список | pgsql-patches |
Does anyone know why we test for pgstat_collect_querystring in routines that obviously dump only block and row-level statistics and database commit/rollback total? Is it a copy/paste error? Patch attached for review. The inclusion of pgstat_collect_querystring in these tests seems like a bug. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 Index: src/backend/postmaster/pgstat.c =================================================================== RCS file: /cvsroot/pgsql/src/backend/postmaster/pgstat.c,v retrieving revision 1.115 diff -c -c -r1.115 pgstat.c *** src/backend/postmaster/pgstat.c 31 Dec 2005 19:39:10 -0000 1.115 --- src/backend/postmaster/pgstat.c 1 Jan 2006 03:31:24 -0000 *************** *** 810,817 **** int i; if (pgStatSock < 0 || ! !(pgstat_collect_querystring || ! pgstat_collect_tuplelevel || pgstat_collect_blocklevel)) { /* Not reporting stats, so just flush whatever we have */ --- 810,816 ---- int i; if (pgStatSock < 0 || ! !(pgstat_collect_tuplelevel || pgstat_collect_blocklevel)) { /* Not reporting stats, so just flush whatever we have */ *************** *** 1224,1231 **** void pgstat_count_xact_commit(void) { ! if (!(pgstat_collect_querystring || ! pgstat_collect_tuplelevel || pgstat_collect_blocklevel)) return; --- 1223,1229 ---- void pgstat_count_xact_commit(void) { ! if (!(pgstat_collect_tuplelevel || pgstat_collect_blocklevel)) return; *************** *** 1256,1263 **** void pgstat_count_xact_rollback(void) { ! if (!(pgstat_collect_querystring || ! pgstat_collect_tuplelevel || pgstat_collect_blocklevel)) return; --- 1254,1260 ---- void pgstat_count_xact_rollback(void) { ! if (!(pgstat_collect_tuplelevel || pgstat_collect_blocklevel)) return;
В списке pgsql-patches по дате отправления: