[ psqlodbc-Bugs-1000432 ] Inconsistent PGAPI_ declarations

Bugs item #1000432, was opened at 2005-11-19 22:07
You can respond by visiting:
http://pgfoundry.org/tracker/?func=detail&atid=538&aid=1000432&group_id=1000125

Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 3
Submitted By: Dave Page  (dpage)
Assigned to: Nobody (None)
Summary: Inconsistent PGAPI_ declarations

Initial Comment:
Some of the internal PGAPI_* functions don't match their definitions. For example, from pgapifunc.h:

RETCODE SQL_API PGAPI_BindParameter(
                    HSTMT hstmt,
                    SQLUSMALLINT ipar,
                    SQLSMALLINT fParamType,
                    SQLSMALLINT fCType,
                    SQLSMALLINT fSqlType,
                    SQLUINTEGER cbColDef,
                    SQLSMALLINT ibScale,
                    PTR rgbValue,
                    SQLINTEGER cbValueMax,
                    SQLINTEGER *pcbValue);

And from bind.c:

PGAPI_BindParameter(
                    HSTMT hstmt,
                    UWORD ipar,
                    SWORD fParamType,
                    SWORD fCType,
                    SWORD fSqlType,
                    UDWORD cbColDef,
                    SWORD ibScale,
                    PTR rgbValue,
                    SDWORD cbValueMax,
                    SDWORD FAR * pcbValue)

With some DMs (notably iODBC);

typedef long int        SDWORD;

#if (SIZEOF_LONG == 8)
typedef signed int        SQLINTEGER;
#else
typedef signed long        SQLINTEGER;
#endif

The declaration (pgapifunc.h) would appear to be correct.

----------------------------------------------------------------------

>Comment By: Dave Page  (dpage)
Date: 2005-11-25 10:44

Message:
I've committed an update that should clean up all of these.

----------------------------------------------------------------------

You can respond by visiting:
http://pgfoundry.org/tracker/?func=detail&atid=538&aid=1000432&group_id=1000125