Re: broken comment justification logic in new pgindent

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Good point.  I see the maximum length changed in this commit:
> >     revision 1.70
> >     date: 2004/10/02 01:10:58;  author: momjian;  state: Exp;  lines: +1 -1
> >     Update length from 75 to 79.
> 
> > We were discussing some pgindent issues at that time on hackers, but I
> > don't see any complaints about the length, so I am unsure why I modified
> > it, but perhaps I received a private communication asking why it wasn't
> > 79.
> 
> I remember that discussion, and I remember we agreed to update it to 79.
> You're missing the point completely: the problem at hand is that
> pgindent is failing to honor its width parameter in some situations.

My guess is that there is a one-off bug in there.

> > Anyway, I have updated the script to be 78,
> 
> This is just going to create a lot of gratutitous re-indents without
> actually fixing the problem, because whatever bug is causing pgindent
> to sometimes not honor the -l switch will still be there.

I have no idea how we are going to find the bug.  I am thinking we need
to just reduce the maximum length until the length is less than 80.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073