Re: [HACKERS] expanded \df+ display broken in beta4

Tom Lane wrote:
> "Michael Paesold"  writes:
> > Robert Treat wrote:
> >> ISTM even a GUC to enable/disable would have been better scheme than
> >> what we have now; we are basically leaving no options for those who
> >> found the old behavior useful, while what we had before would at least
> >> let people switch back and forth. 
> 
> > I think Robert is right here and the new behaviour is a step backwards.
> 
> Should we revert the patch for the time being, and take another go at it
> in 8.2?
> 
> Is it practical to have the old behavior for \df (and anything else with
> particularly wide output) while still forcing \x off for \d?

Here is a quick patch, not for application, that makes \df+ honor \x,
but not \df.  Basicaly verbose honors \x, non-verbose does not.  I think
would need renaming of the normal_query variable, and more checking in
the code to make sure we are OK.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/bin/psql/command.c
===================================================================
RCS file: /cvsroot/pgsql/src/bin/psql/command.c,v
retrieving revision 1.154
diff -c -c -r1.154 command.c
*** src/bin/psql/command.c	15 Oct 2005 02:49:40 -0000	1.154
--- src/bin/psql/command.c	26 Oct 2005 00:00:11 -0000
***************
*** 305,311 ****
  										 OT_NORMAL, NULL, true);
  
  		show_verbose = strchr(cmd, '+') ? true : false;
! 
  		switch (cmd[1])
  		{
  			case '\0':
--- 305,315 ----
  										 OT_NORMAL, NULL, true);
  
  		show_verbose = strchr(cmd, '+') ? true : false;
! 		if (show_verbose)
! 			pset.popt.topt.normal_query = true;
! 		else
! 			pset.popt.topt.normal_query = false;
! 		
  		switch (cmd[1])
  		{
  			case '\0':