Re: [HACKERS] Patching dblink.c to avoid warning about
От | Bruce Momjian |
---|---|
Тема | Re: [HACKERS] Patching dblink.c to avoid warning about |
Дата | |
Msg-id | 200510171236.j9HCa0L00844@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: [HACKERS] Patching dblink.c to avoid warning about (Joe Conway <mail@joeconway.com>) |
Ответы |
Re: [HACKERS] Patching dblink.c to avoid warning about
|
Список | pgsql-patches |
Joe Conway wrote: > Tom Lane wrote: > > I think it would be shorter and clearer to write > > > > remoteConn *remconn = NULL; > > ... > > remconn = rconn; > > ... > > remconn->newXactForCursor = TRUE; > > > > Also, you might be able to combine this variable with the existing > > rconn local variable and thus simplify the code even more. > > Thanks for the review Tom -- as usual, great suggestions. The attached > (simpler) patch makes use of your advice. If there are no objections, > I'll apply this tomorrow evening. Looks good. Thanks. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
В списке pgsql-patches по дате отправления: