Re: Simplifying unknown-literal handling
От | Alvaro Herrera |
---|---|
Тема | Re: Simplifying unknown-literal handling |
Дата | |
Msg-id | 20050529171355.GA7005@surnet.cl обсуждение исходный текст |
Ответ на | Simplifying unknown-literal handling (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: Simplifying unknown-literal handling
|
Список | pgsql-hackers |
On Sun, May 29, 2005 at 11:47:18AM -0400, Tom Lane wrote: > For the past couple of releases we've had support for cstring > (null-terminated string) as a full fledged datatype: you set > typlen = -2 to indicate that strlen() must be used to calculate > the actual size of a Datum. > > It occurs to me that we should change type UNKNOWN's internal > representation to be like cstring rather than like text. The > advantage of this is that the places in the parser that currently > call unknownin and unknownout could be replaced by just > CStringGetDatum and DatumGetCString, respectively, thus saving > two palloc's and two memcpy's per string literal. It's not much, > but considering that this happens every time we parse a string > literal, I think it'll add up to a savings worth the small amount > of effort needed. > > Anyone see a reason not to change this? Is there any way we use UNKNOWN to represent bytea literals? Say, comparing a untyped literal to a bytea column? -- Alvaro Herrera (<alvherre[a]surnet.cl>) "Sallah, I said NO camels! That's FIVE camels; can't you count?" (Indiana Jones)
В списке pgsql-hackers по дате отправления: