Re: [PATCHES] A way to let Vacuum warn if FSM settings are low.

Tom Lane wrote:
> Ron Mayer <rm_pg@cheapcomplexdevices.com> writes:
> > Should the relation overflow be a WARNING or a LOG?  It sounds like
> > if you have that problem it's almost certainly a problem, right?
>
> I'd go for making them both LOG, I think.  More consistent.

Can we also update this wording:

INFO:  free space map: 52 relations, 61 pages stored; 848 total pages needed
DETAIL:  Allocated FSM size: 1000 relations + 20000 pages = 182 kB shared memory.

The "pages needed" is confusing.  In fact it is the total pages used or
allocated.  I looked in the code and got confused.  It needs clarity.
Right now it sounds like you need more when you don't.


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073