Re: [GENERAL] WARNING: could not remove database directory

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Tom Lane wrote:
> >> [ looks at code... ]  dbcommands.c is expecting that rmtree() will have
> >> printed out a more-detailed message about the problem, but someone has
> >> carefully removed every trace of error reporting from rmtree().
> 
> > I think the issue is that we didn't want different object files for
> > client and server output message and and returning error codes and
> > having every calling location print strings was unmaintainable.
> 
> But we already bit that bullet.  Look at the other routines in dirmod.c:
> 
> #ifndef FRONTEND
>         ereport(ERROR,
>                 (errcode_for_file_access(),
>                  errmsg("Error setting junction for %s: %s",
>                         nativeTarget, msg)));
> #else
>         fprintf(stderr, "Error setting junction for %s: %s\n",
>                 nativeTarget, msg);
> #endif
> 
> It's certainly not realistic to pass back enough information from
> rmtree() to let the caller print a useful error message, so I think
> we have to add reporting code along this line to rmtree().

Agreed.  Not sure how the rmtree stuff was removed.  I will look into
re-adding it, I assume for 8.1 only not 8.0.X?

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073