Re: sparse (static analyzer) report

On Fri, Jan 14, 2005 at 03:53:09PM -0800, Mark Wong wrote:
> On Thu, Jan 13, 2005 at 03:09:19PM -0800, Mark Wong wrote:
> > On Thu, Jan 13, 2005 at 08:06:23PM -0300, Alvaro Herrera wrote:
> > > On Thu, Jan 13, 2005 at 01:31:36PM -0800, Mark Wong wrote:
> > > > We've also started automating sparse analyses in our PLM tool, which
> > > > will show an error and warning count.  Here's an example:

>     http://developer.osdl.org/markw/pgsql/sparse/pg-8.0rc5.html

Hmm.  Well, it showed the multiple incorrect uses of 0 as NULL in
dllist.c and other places, but there's still lots of spurious entries.
See backend/transam/xlog.c: it's strange that the parser is so confused
about XLogCtrl, for example.

It's complaining in several places about function as variables in
function declarations (the multiple walkers and mutators for example);
not sure how correct that is.

It is also analyzing flex and bison output files ... is it capable of
analyzing .y and .l files instead?

It's strange that DatumGetInt32 shows as a undefined identifier ...
there's some problem with postgres.h apparently.  And fmgroids.h is
missing; not sure what's the minimal make target to install it, because
make -C src/backend/utils fmgroids.h
generates it, but the symbolic link to src/include/utils is still
needed.

-- 
Alvaro Herrera (<alvherre[@]dcc.uchile.cl>)
"La gente vulgar solo piensa en pasar el tiempo;
el que tiene talento, en aprovecharlo"