Re: cygwin build failure

Andrew Dunstan wrote:
> As requested by Reini I set up a Cygwin buildfarm client, and immediately got this build failure:
> 
> 
> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wendif-labels -fno-strict-aliasing -g pg_dump.o common.o
pg_dump_sort.opg_backup_archiver.o pg_backup_db.o pg_backup_custom.o pg_backup_files.o pg_backup_null.o pg_backup_tar.o
dumputils.o ../../../src/backend/parser/keywords.o -L../../../src/interfaces/libpq -lpq -L../../../src/port
-L/usr/local/lib -lpgport -lcrypt -o pg_dump.exe
 
> ../../../src/port/libpgport.a(pgstrcasecmp.o)(.text+0x1b0): In function `pg_tolower':
> /home/adunstan/pgbf/root/HEAD/pgsql.3200/src/port/pgstrcasecmp.c:119: multiple definition of `_pg_tolower'
> ../../../src/interfaces/libpq/libpq.a(dshcs00145.o)(.text+0x0): first defined here
> Info: resolving _optarg by linking to __imp__optarg (auto-import)
> Info: resolving _optind by linking to __imp__optind (auto-import)
> collect2: ld returned 1 exit status
> make[3]: *** [pg_dump] Error 1
> 
> see http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gibbon&dt=2004-11-06%2018:11:58

The _pg_tolower problem started when I changed exec.c to use the more
standard pg_strcasecmp rather than stricmp.   I am confused why this
caused a problem however because libpgport has pg_tolower because it has
pgstrcasecmp.c.  Any ideas?

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073