Re: psql \! WIN32 cleanup

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > The attached applied patch tests for COMSPEC in the right place and
> > supplies a reasonable shell default on Win32.
>
> > + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe"
>
> Is it really a good idea to assume that the Windows installation is on
> drive C: ?
>
> (This is an honest question, not a rhetorical one.  I dunno whether
> inserting the C: is better than leaving it off.  I can think of cases
> where either way will break, but I'm unsure what's most likely in
> practice.)

Not sure.  Should we just do "/windows/system32/cmd.exe" and leave off
the C:?  The previous default was "/bin/sh" and that certainly will not
work on Win32.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073