Re: All three packages ...

On Thu, 19 Aug 2004, Tom Lane wrote:

> One other little problem with the 7.2.5 package: I see you rebuilt the
> flex and bison output files with our current versions of those tools.
> I think this is probably okay, but it changes the expected output of
> some of the regression tests, eg
>
> *** ./expected/strings.out    Fri Jun  1 13:49:17 2001
> --- ./results/strings.out    Thu Aug 19 12:08:22 2004
> ***************
> *** 17,23 ****
>  ' - next line' /* this comment is not allowed here */
>  ' - third line'
>      AS "Illegal comment within continuation";
> ! ERROR:  parser: parse error at or near "'"
>  --
>  -- test conversions between various string types
>  --
> --- 17,23 ----
>  ' - next line' /* this comment is not allowed here */
>  ' - third line'
>      AS "Illegal comment within continuation";
> ! ERROR:  parser: syntax error at or near "'"
>  --
>  -- test conversions between various string types
>  --
>
> A really paranoid person might complain that we have not adequately
> tested that the 7.2 code base will work with the updated tools.
> I don't think this is a big deal (I did run through the regression
> tests to verify this...) but we will need to fix the regression
> expected outputs if we want to do it this way.
>
> If you want to proceed, let me know and I'll commit the updated
> regression outputs into the 7.2 branch, and then we can re-wrap.

Let's go with the updated regression outputs ... probably better then 
going and reverting down flex/bison just for packaging :(


----
Marc G. Fournier           Hub.Org Networking Services (http://www.hub.org)
Email: scrappy@hub.org           Yahoo!: yscrappy              ICQ: 7615664