Re: The new try/catch macros
От | Bruce Momjian |
---|---|
Тема | Re: The new try/catch macros |
Дата | |
Msg-id | 200408090138.i791c0t05494@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: The new try/catch macros (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-hackers |
Tom Lane wrote: > Thomas Hallgren <thhal@mailblocks.com> writes: > > 1. You use a do {...} while(0) construct to wrap the whole thing. This > > actually makes it impossible to write code that does a try/catch within > > a loop that contains code surrounding it since a continue or break will > > then end up in the wrong place. > > A continue or break exiting the construct would do the wrong thing > anyway, so I don't see that removing the do{} is very helpful. The > point of having it is to make sure that a try/end try block is > syntactically like a statement, rather than like a { ... } construct. > > > 3. IMHO, it's a bit ugly to require parenthesis and semicolons at the > > end of the macros. > > This isn't really open for debate, because if we don't put that there, > pg_indent will go nuts. > Could we just teach pgindent about these macros? -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
В списке pgsql-hackers по дате отправления: