Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path

Tom Lane wrote:
> momjian@svr1.postgresql.org (Bruce Momjian) writes:
> > Use strdup in pg_ctl for canonicalize_path on environment variable.
> > Simplify postmaster call too.
>
> You're not doing very well with this project :-(.  pg_ctl is now
> actively broken, because the PGDATA value passed down to the
> bootstrap backend is the one in the environment variable.  The
> previous coding canonicalized that, this does not.

I didn't think we could modify the environment variables like that
portably.   Also, it is not even needed because we now do the proper
canonicalization in the postmaster.

> I do not like the "simplified" postmaster.c coding either; it may
> save one line but it is harder to understand.

OK, reverted that part.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073