Re: Tablespace patch review

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Tom Lane wrote:
> >> I should think that the table-level display ought to show both the
> >> relfilenode and tablespace OIDs for each table.
>
> > For objects in the default tablespace, they don't show a tablespace oid,
> > right?  Where do we put it?  A column that will be empty if they don't
> > use tablespaces?
>
> pg_class will show a zero for objects in the default tablespace, but
> I think oid2name should pull the actual tablespace ID from
> pg_database.dattablespace and show that.  The convention about zero
> is just to make life simple for CREATE DATABASE --- users of oid2name
> should not have to think about it.

Well, I didn't use tablespaces here so the pg_tablespaces directory is
empty, so I can't think of what the tablespace is.  Is it the database
oid?   Also, are we calling it pg_tablespaces (plural) rather than
pg_tablespace?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073