Re: pg_ctl patch to integrate apache's rotatelogs

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > Ouch.  How long has that documentation been wrong?  We have
> > > pointed folks to that section of the docs tons of times, and no
> > > one mentioned that "logrotate" is really "rotatelogs", and that
> > > it is missing parameters?
> > >
> > > I have applied the following patch to document rotatelogs
> > > properly.
> >
> > I think you just broke it.  logrotate and rotatelogs are two
> > different programs, and AFAIK the existing documentation correctly
> > described the one that is easier to use with Postgres.
>
> Oh, why don't I have logrotate.  My system has:
>
>        rotatelogs - rotate Apache logs without having to kill the
>        server
>
>        rotatelogs logfile rotationtime [offset]
>
> and it says it is Apache's.  I must be wrong but can someone explain
> this?

logrotate rotates log files and hups the servers according to a
configuration file.  rotatelogs reads the log data on stdin and reopens
a new output file once in a while.  The first hunk of your patch was
wrong, the rest seemed OK.