Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> Here are two patches that refactor the mostly repetitive "${object} is
> visible" and get_${object}_oid() functions in namespace.c. This uses
> the functions in objectaddress.c to look up the appropriate per-catalog
> system caches and attribute numbers, similar to other refactoring
> patches I have posted recently.
This does not look like a simple refactoring patch to me. I have
very serious concerns first about whether it even preserves the
existing semantics, and second about whether there is a performance
penalty.
regards, tom lane