Re: junit failure?

On Sun, Nov 16, 2003 at 07:42:09PM -0500, Kris Jurka wrote:
>
>
> On Sun, 16 Nov 2003, Larry Rosenman wrote:
>
> > On 7.4RC2 (from today's CVS, -rREL7_4_STABLE), I get:
> > runtest:
> >     [junit] Testsuite: org.postgresql.test.jdbc2.Jdbc2TestSuite
> >     [junit] Tests run: 87, Failures: 1, Errors: 0, Time elapsed: 13.759 sec
> >
> >     [junit] Testcase:
> > testTables(org.postgresql.test.jdbc2.DatabaseMetaDataTest):       FAILED
> >     [junit] null
> >     [junit] junit.framework.AssertionFailedError
> >     [junit]     at
> > org.postgresql.test.jdbc2.DatabaseMetaDataTest.testTables(DatabaseMetaDataT
> > est.java:64)
>
> Tough to tell what the problem is exactly.  The JDBC tests don't have the
> equivalent of the main regression test's diffs that you can send around.
> This test could fail if you had a table in the database you are running
> this against that had a name starting with "test".  Please try out the
> attached patch which adds some debug info for this particular failure.

Here's a quick patch that changes some of the assertTrue calls to
assertEquals, which produces a more useful assertion failure message.

-O