Re: psql client 7.4RC1 completion bug

Oliver Siegmar wrote:
> ============================================================================
>                         POSTGRESQL BUG REPORT TEMPLATE
> ============================================================================
>
>
> Your name               : Oliver Siegmar
> Your email address      : oliver.siegmar@xams.org
>
>
> Please enter a FULL description of your problem:
> ------------------------------------------------
>
> psql -U username template1
> template1=# alter database databasename <TAB><TAB>
> RESET  SET
> template1=# \h alter database
> Command:     ALTER DATABASE
> Description: change a database
> Syntax:
> ALTER DATABASE name SET parameter { TO | = } { value | DEFAULT }
> ALTER DATABASE name RESET parameter
>
> ALTER DATABASE name RENAME TO newname
>
>
> ...the psql Tab completion doesn't show the rename command.

OK, found the bug.  With the attached patch, it now show:

    test=> ALTER DATABASE test
    RENAME TO  RESET      SET

This will appear in 7.4 final.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/bin/psql/tab-complete.c
===================================================================
RCS file: /cvsroot/pgsql-server/src/bin/psql/tab-complete.c,v
retrieving revision 1.92
diff -c -c -r1.92 tab-complete.c
*** src/bin/psql/tab-complete.c    6 Nov 2003 22:08:15 -0000    1.92
--- src/bin/psql/tab-complete.c    8 Nov 2003 20:51:48 -0000
***************
*** 645,651 ****
               strcasecmp(prev2_wd, "DATABASE") == 0)
      {
          static const char *const list_ALTERDATABASE[] =
!         {"RESET", "SET", NULL};

          COMPLETE_WITH_LIST(list_ALTERDATABASE);
      }
--- 645,651 ----
               strcasecmp(prev2_wd, "DATABASE") == 0)
      {
          static const char *const list_ALTERDATABASE[] =
!         {"RESET", "SET", "RENAME TO", NULL};

          COMPLETE_WITH_LIST(list_ALTERDATABASE);
      }