Re: fix for strict-alias warnings

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Patch applied.  Thanks.
>
> I hope you applied it with the additional changes you asked for ---
> at the very least, cast to (void*) and then to the destination type.
> As-is, the patch simply suppresses all error detection for these
> conversions, which seems a bad move.

I don't have a version that does the double-cast, but I still have the
patch to back out and put in a new one.  Andrew's point was that we cast
to void * in many places, so this case is not unique.  Is that wrong?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073