Re: Use of $(THREAD_CFLAGS) in CPPFLAGS

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I just noticed that libpq/ecpg use $(THREAD_CFLAGS) as part of CPPFLAGS.
> > Is that correct?  Should it be added to CFLAGS instead?
> 
> I was just noticing that today.  THREAD_CFLAGS typically includes -D
> flags, and as such it *must* be added to CPPFLAGS --- it'd be incorrect
> to add it to CFLAGS.  Possibly we should rename THREAD_CFLAGS to 
> THREAD_CPPFLAGS.  I'm not sure that we have any platforms for which it
> would be useful to invent both THREAD_CPPFLAGS and THREAD_CFLAGS.

Actually, the most common THREAD_CFLAGS is -pthread, used by Solaris,
OSF, and FreeBSD 4.X.  Only Linux uses -D flags for threading.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073