Re: Testing the return value of fclose() in the backend

Gavin Sherry wrote:
> Hi all,
> 
> There are various places in the backend, such as FreeFile(), where the
> return value of fclose() is not tested. Whilst we would often notice any
> problems with writing to data files due to testing on fsync(), it could
> affect things like COPY ... TO, CreateOptsFile() and more.
> 
> Are we catching these somewhere else I'm not seeing?

We are not checking fclose, probably because fclose failures are quite
rare.  Should we be concerned?

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073