Re: cleanup of cbrt() handling
| От | Bruce Momjian | 
|---|---|
| Тема | Re: cleanup of cbrt() handling | 
| Дата | |
| Msg-id | 200305251406.h4PE6Be13500@candle.pha.pa.us обсуждение исходный текст | 
| Ответ на | Re: cleanup of cbrt() handling (Tom Lane <tgl@sss.pgh.pa.us>) | 
| Ответы | Re: cleanup of cbrt() handling | 
| Список | pgsql-patches | 
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > This patch cleans up our static cbrt() implementation in float.c.
>
> Looks like an improvement to me.
Yep, however, now that I look at the original code, and code that
shipped in 7.3:
    #ifndef HAVE_CBRT
    #define cbrt my_cbrt
    static double cbrt(double x);
    #else
    #if !defined(nextstep)
    extern double cbrt(double x);
    #endif
    #endif   /* HAVE_CBRT */
There is no my_cbrt() function, meaning anyone who didn't have cbrt
couldn't have even compiled 7.3, so I think we should just remove cbrt,
or mark it as UNUSED.
--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
		
	В списке pgsql-patches по дате отправления: