Re: Win32 defines

Tom Lane wrote:
> Why is this removing the use of the TIMEZONE_GLOBAL macro?

It was Peter's suggestion.  Once we had a port-specific define, we
should use timezone directly, no?

---------------------------------------------------------------------------

> Index: src/include/utils/datetime.h
> ===================================================================
> RCS file: /cvsroot/pgsql-server/src/include/utils/datetime.h,v
> retrieving revision 1.36
> diff -c -c -r1.36 datetime.h
> *** src/include/utils/datetime.h      20 Feb 2003 05:24:55 -0000      1.36
> --- src/include/utils/datetime.h      3 Apr 2003 06:09:41 -0000
> ***************
> *** 217,223 ****
>   #endif
>
>   /* Global variable holding time zone information. */
> ! #if defined(__CYGWIN__) || defined(N_PLAT_NLM)
>   #define TIMEZONE_GLOBAL _timezone
>   #else
>   #define TIMEZONE_GLOBAL timezone
> --- 217,223 ----
>   #endif
>
>   /* Global variable holding time zone information. */
> ! #if defined(__CYGWIN__) || defined(WIN32) || defined(N_PLAT_NLM)
>   #define TIMEZONE_GLOBAL _timezone
>   #else
>   #define TIMEZONE_GLOBAL timezone

We should move that to the port-specific include files, like

#define timezone _timezone


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073