Re: regression failure - horology
От | Bruce Momjian |
---|---|
Тема | Re: regression failure - horology |
Дата | |
Msg-id | 200303200445.h2K4jC721004@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: regression failure - horology ("Jeroen T. Vermeulen" <jtv@xs4all.nl>) |
Список | pgsql-hackers |
Patch attached and applied. Thanks. --------------------------------------------------------------------------- Jeroen T. Vermeulen wrote: > On Sat, Feb 22, 2003 at 03:09:13AM -0500, Tom Lane wrote: > > > > Mph. It fails for me too when I use --enable-integer-datetimes. Looks > > like that patch still needs some work... > > Yeah. I'm really, really, *really* sorry for submitting it in the state > it was in. I shouldn't have done that just before moving to another > country. I found the problem last night, but couldn't get to a Net > connection until now. > > The problem is in src/bin/psql/common.c, around line 250-335 somewhere > depending on the version. The 2nd and 3rd clauses of the "while" loop > condition: > > (rstatus == PGRES_COPY_IN) && > (rstatus == PGRES_COPY_OUT)) > > should of course be: > > (rstatus != PGRES_COPY_IN) && > (rstatus != PGRES_COPY_OUT)) > > > Jeroen > > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 Index: src/bin/psql/common.c =================================================================== RCS file: /cvsroot/pgsql-server/src/bin/psql/common.c,v retrieving revision 1.57 diff -c -c -r1.57 common.c *** src/bin/psql/common.c 18 Mar 2003 22:15:44 -0000 1.57 --- src/bin/psql/common.c 20 Mar 2003 04:44:04 -0000 *************** *** 252,259 **** } PQclear(res); res = newres; ! if (rstatus == PGRES_COPY_IN || ! rstatus == PGRES_COPY_OUT) break; } } --- 252,259 ---- } PQclear(res); res = newres; ! if (rstatus != PGRES_COPY_IN && ! rstatus != PGRES_COPY_OUT) break; } }
В списке pgsql-hackers по дате отправления: