Re: PGRES_POLLING_ACTIVE is unused...

This change will be made to the poll patch:


Your patch has been added to the PostgreSQL unapplied patches list at:

    http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Tom Lane wrote:
> Lennert Buytenhek <buytenh@gnu.org> writes:
> > ...any reason why it is there at all?
>
> Good question.  Some digging in CVS shows that it was unused even in the
> patch that introduced it, and never has been used in any release since.
> So it does seem like useless complication.
>
> However, I think it'd be unwise to remove the constant from libpq-fe.h,
> because that would break the application of any poor sod who believed
> the documentation and wrote code that actually checks for
> PGRES_POLLING_ACTIVE.
>
> I'd be inclined to remove it from the documentation and the library
> innards, but leave something like this in libpq-fe.h:
>
>     PGRES_POLLING_ACTIVE    /* unused; keep for awhile for
>                  * backwards compatibility */
>
>
>             regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073