Re: ON COMMIT temp table handling

Gavin Sherry wrote:
> > o  Your code in cluster.c called heap_create_with_catalog() using:
> >
> >     isTempNamespace(RelationGetNamespace(OldHeap)),
> >
> > which returns a boolean, and passes it as the value for 'ateoxact',
> > which is not a boolean.  This call is used to create the new heap file
> > for the cluster operation.  I changed it to ATEOXACTNOOP.
>
> I haven't looked at the patch because its a bit chaotic here after getting
> back, but it occurs to me that if the cluster is on a temp table we want
> to tell heap_create_with_catalog().

The flag we being passed for the creation of the new heap, which was
going to be deleted anyway when the transaction finished.  Why bother
passing anything special for it?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073