Re: PQcmdTuples() declaration

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > The issue with PQcmdTuples() and PQcmdStatus() are that they return
> > *result structure member pointers.  The patch makes the *result a const,
> > then we have to return the values as const's.  The code compiled OK, so
> > I assume that is fine.  How does that sound to others, or should we keep
> > the result non-const?
> 
> Adding a const to the result type will break client applications that
> aren't expecting it.  I don't think we can get away with that.
> 
> We could still declare the input type as const if we were willing to
> cast away const inside the functions, but that seems pretty ugly.

Yep, seems pretty ugly to me too.  Why bother calling it a const if we
are going to cast it away.

I have updated the docs for 7.3 and CVS to match the non-const code. 
Let's see if this issue comes up again.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073