Re: Cleanup of /contrib

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I am cleaning up /contrib by adding "autocommit = 'on'" and making it
> > more consistent.  Should I be adding this too:
> 
> >     -- Adjust this setting to control where the objects get created.
> >     SET search_path = public;
> 
> Yes, that would be a good idea.  Without that, the objects might well
> get created in the owning user's private schema; which most of the time
> would be unhelpful.  I'm not thrilled with having to edit the script
> if you do happen to want them in a non-public schema, but I have not
> thought of a better approach yet.  (Anyone?)
> 
> > and doing all object creation in one transaction, like /contrib/cube
> > does?
> 
> The one-transaction thing seems unnecessary to me, but if you like it...

Some have it, some don't. I will make it consistent, at least.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073