Re: Trigger regression test output

Tom Lane wrote:
> I said:
> > I am inclined to have the refint.c code emit the notice unconditionally
> > at DEBUG1 level, and then add a "SET client_min_messages = DEBUG1" in
> > the triggers regression test to ensure the notice will appear.
> 
> Hmm, that doesn't look that good after all: the SET causes the
> regression output to be cluttered with a whole *lot* of chatter,
> which will doubtless change constantly and break the test regularly.
> 
> Plan B is to make the refint.c code emit the message at NOTICE level,
> but to change the contrib makefile so that REFINT_VERBOSE is defined
> by default (ie, you gotta edit the makefile if you don't want it).
> This will work nicely for the regression tests' purposes.  If there is
> anyone out there actually using refint.c in production, they might be
> annoyed by the NOTICE chatter, but quite honestly I doubt anyone is ---
> this contrib module has long since been superseded by standard
> foreign-key support.

Yes, but if few people are using it, should we question whether it
belongs in the standard regression tests at all?

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073