Re: making use of large TLB pages

Tom Lane wrote:
> Neil Conway <neilc@samurai.com> writes:
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >> OK, personally, I would like to see an actual speedup of PostgreSQL
> >> queries before I would apply such a OS-specific, version-specific
> >> patch.
> 
> > Don't be silly. A performance improvement is a performance
> > improvement.
> 
> No, Bruce was saying that he wanted to see demonstrable improvement
> *due to this specific change* before committing to support a
> platform-specific API.  I agree with him, actually.  If you do the
> TLB code and can't measure any meaningful performance improvement
> when using it vs. when not, I'd not be excited about cluttering the
> distribution with it.
> 
> > I think it's at least worth implementing -- if it doesn't provide a
> > noticeable performance improvement, then we don't need to merge it.
> 
> You're on the same page, you just don't realize it...

I see what he thought I said, I just can't figure out how he read it
that way.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073