Re: FUNC_MAX_ARGS benchmarks

Change made.

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > In fact, I now see that there was no such problem.  I do wonder why the
> > 32 is there, though? Shouldn't it be 6 or something like that?
> 
> Whoever it was was too lazy to count accurately ;-)
> 
> I guess I'd vote for changing the code to be
> 
>     sys = malloc(strlen(editorName) + strlen(fname) + 10 + 1);
>     if (!sys)
>         return false;
>     sprintf(sys, "exec '%s' '%s'", editorName, fname);
> 
> (note the added quotes to provide a little protection against spaces
> and such).  Then it's perfectly obvious what the calculation is doing.
> I don't care about wasting 20-some bytes, but confusing readers of the
> code is worth avoiding.
> 
>             regards, tom lane
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073