Re: FUNC_MAX_ARGS benchmarks

In fact, I now see that there was no such problem.  I do wonder why the
32 is there, though? Shouldn't it be 6 or something like that?

---------------------------------------------------------------------------

Neil Conway wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I have applied the attached patch which changes NAMEDATALEN to 64 and
> > FUNC_MAX_ARGS/INDEX_MAX_KEYS to 32.
> 
> What is the reasoning behind the following change?
> 
> Index: src/bin/psql/command.c
> ===================================================================
> RCS file: /cvsroot/pgsql-server/src/bin/psql/command.c,v
> retrieving revision 1.75
> diff -c -r1.75 command.c
> *** src/bin/psql/command.c    10 Aug 2002 03:56:23 -0000    1.75
> --- src/bin/psql/command.c    13 Aug 2002 20:18:01 -0000
> ***************
> *** 1513,1519 ****
>       sys = malloc(strlen(editorName) + strlen(fname) + 32 + 1);
>       if (!sys)
>           return false;
> !     sprintf(sys, "exec %s %s", editorName, fname);
>       result = system(sys);
>       if (result == -1)
>           psql_error("could not start editor %s\n", editorName);
> --- 1513,1519 ----
>       sys = malloc(strlen(editorName) + strlen(fname) + 32 + 1);
>       if (!sys)
>           return false;
> !     snprintf(sys, 32, "exec %s %s", editorName, fname);
>       result = system(sys);
>       if (result == -1)
>           psql_error("could not start editor %s\n", editorName);
> 
> Cheers,
> 
> Neil
> 
> -- 
> Neil Conway <neilconway@rogers.com>
> PGP Key ID: DB3C29FC
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073