Re: Inefficient handling of LO-restore + Patch

Mario Weilguni wrote:
> Am Mittwoch, 24. April 2002 16:03 schrieb Bruce Momjian:
> > OK, I have applied the following patch to fix these warnings.  However,
> > I need Mario to confirm these are the right changes.  Thanks.
> 
> I've checked it and works fine, but the memcpy() prototype says it should be 
> void pointers. Will this give errors with non-gcc compilers?

No, it is fine.  Anything can be cast _to_ a void pointer.  You just
can't do arithmetic on them.

Are you sure you want to use 'void *' in your code.  Looking at the
backend large object code, I see char *:
 extern int  inv_read(LargeObjectDesc *obj_desc, char *buf, int nbytes); extern int  inv_write(LargeObjectDesc
*obj_desc,char *buf, int nbytes);
 

I guess my point is that these are just streams of bytes, _not_ really
streams of items of unknown length.  We know the length, and the length
is char.  This may simplify the code.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026