Re: unknownin/out patch (was [HACKERS] PQescapeBytea is not

OK, patch applied, and regression tests now patch.  Thanks.

---------------------------------------------------------------------------

Tom Lane wrote:
> Joe Conway <mail@joeconway.com> writes:
> > ... I guess the question is whether
> > or not unknownin/out should be marked proimplicit = 't' or not.
>
> AFAIR there are no I/O routines that should be marked proimplicit = 't'.
> We don't allow "C string" to be handled as part of the type system,
> and until we do it doesn't make any sense to allow implicit conversions
> to or from "C string".
>
> The oprsanity tests are still a few bricks shy of a load w.r.t. the
> recent pg_proc and namespace changes --- I hope to add more checks soon.
>
>             regards, tom lane
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
Index: src/include/catalog/pg_proc.h
===================================================================
RCS file: /cvsroot/pgsql/src/include/catalog/pg_proc.h,v
retrieving revision 1.231
diff -c -r1.231 pg_proc.h
*** src/include/catalog/pg_proc.h    24 Apr 2002 03:09:09 -0000    1.231
--- src/include/catalog/pg_proc.h    24 Apr 2002 05:02:43 -0000
***************
*** 237,245 ****
  DATA(insert OID = 108 (  scalargtjoinsel   PGNSP PGUID 12 f t f t f s 3 701 "0 26 0" 100 0 0 100  scalargtjoinsel -
_null_)); 
  DESCR("join selectivity of > and related operators on scalar datatypes");

! DATA(insert OID =  109 (  unknownin           PGNSP PGUID 12 f t t t f i 1 705 "0" 100 0 0 100    unknownin - _null_
));
  DESCR("(internal)");
! DATA(insert OID =  110 (  unknownout       PGNSP PGUID 12 f t t t f i 1 23  "0" 100 0 0 100    unknownout - _null_
));
  DESCR("(internal)");

  DATA(insert OID = 112 (  text               PGNSP PGUID 12 f t t t f i 1  25 "23" 100 0 0 100  int4_text - _null_ ));
--- 237,245 ----
  DATA(insert OID = 108 (  scalargtjoinsel   PGNSP PGUID 12 f t f t f s 3 701 "0 26 0" 100 0 0 100  scalargtjoinsel -
_null_)); 
  DESCR("join selectivity of > and related operators on scalar datatypes");

! DATA(insert OID =  109 (  unknownin           PGNSP PGUID 12 f t f t f i 1 705 "0" 100 0 0 100    unknownin - _null_
));
  DESCR("(internal)");
! DATA(insert OID =  110 (  unknownout       PGNSP PGUID 12 f t f t f i 1 23  "0" 100 0 0 100    unknownout - _null_
));
  DESCR("(internal)");

  DATA(insert OID = 112 (  text               PGNSP PGUID 12 f t t t f i 1  25 "23" 100 0 0 100  int4_text - _null_ ));