Re: regression tests for ALTER TABLE ... DEFAULT

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >> Don't you ever run the tests before checking stuff in?
>
> > ... Nope.  I do it once a batch is checked in.  I assume submitters have
> > already done it.  Too much work.
>
> Whether or not you assume that the submitter ran regress tests, it's
> unsafe to assume that a several-days-old patch is still good against
> current CVS tip.  Especially not when you get merge failures, as you
> certainly must have in this case.

Proper patch testing requires initdb and regression tests.  I do those
at the end of a batch of patches, not for each one.

If you want to agitate that there are problems with my patch
application, go ahead.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026