Re: [PATCHES] YADP - Yet another Dependency Patch
От | Bruce Momjian |
---|---|
Тема | Re: [PATCHES] YADP - Yet another Dependency Patch |
Дата | |
Msg-id | 200204160515.g3G5FBp12923@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: [PATCHES] YADP - Yet another Dependency Patch ("Rod Taylor" <rbt@zort.ca>) |
Список | pgsql-hackers |
Rod Taylor wrote: > [ copied to hackers ] > > > 1. I don't like the code that installs and removes ad-hoc > dependencies > > from relations to type Oid. On its own terms it's wrong (if it were Looks good to me. I realize this is a huge chunk of code. The only ultra-minor thing I saw was the use of dashes for comment blocks when not needed: /* ---- * word * ---- */ We use dashes like this only for comments that shouldn't be reformatted by pgindent. The one thing I would like to know is what things does it track, and what does it not track? Does it complete any TODO items, or do we save that for later? -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
В списке pgsql-hackers по дате отправления: