Re: pg_dump is broken in CVS tip

I will apply shortly because pg_dump is broken.  I will give it 8 hours.

Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Neil Conway wrote:
> On Fri, 12 Apr 2002 19:24:21 -0400
> "Neil Conway" <nconway@klamath.dyndns.org> wrote:
> > When I built the current CVS code, both test-case exhibits the
> > problem quite obviously. Therefore, it seems that the problem
> > has been introduced recently.
> 
> The problem was introduced here:
> 
> ------------------
> revision 1.246
> date: 2002/04/05 11:51:12;  author: momjian;  state: Exp;  lines: +129 -3
> Adds domain dumping support to pg_dump.
> 
> Rod Taylor
> ------------------
> 
> Rod's patch does what it is supposed to do, but it also includes
> some old code to add PK constraints to CREATE TABLE. That stuff
> had been removed as part of my original patch for pg_dump a
> little while ago.
> 
> The attached patch fixes this by removing (again :-) ) the
> code in dumpTables() to perform PK creation during CREATE
> TABLE. I briefly tested it locally and it fixes both of
> Tom's test cases.
> 
> Please apply.
> 
> Cheers,
> 
> Neil
> 
> -- 
> Neil Conway <neilconway@rogers.com>
> PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026