Re: libpgtcl pg_execute

This was applied March 4.  I was not sure you had been informed so I am
sending this email.

---------------------------------------------------------------------------

ljb wrote:
> tgl@sss.pgh.pa.us wrote:
> 
> > Looking at the CVS logs, I see that Jan added this command; he should be
> > blamed for not having added any documentation.  Feel free to contribute
> > a documentation patch ...
> 
> I have documentation, but just as plain text. Unfortunately I don't have
> the tools or know-how to get it (correctly) into SGML at this time.
> What should I do?
> 
> > What's wrong with the -oid code?
> 
> pg_execute throws an error when you use -oid (with no error message), because
> the return value check on Tcl_SetVar is wrong.  Here's the fix:
> 
> *** src/interfaces/libpgtcl/pgtclCmds.c.orig    Mon Dec  3 09:49:46 2001
> --- src/interfaces/libpgtcl/pgtclCmds.c    Mon Feb 18 17:25:27 2002
> ***************
> *** 909,915 ****
>   
>           sprintf(oid_buf, "%u", PQoidValue(result));
>           if (Tcl_SetVar(interp, oid_varname, oid_buf,
> !                        TCL_LEAVE_ERR_MSG) != TCL_OK)
>           {
>               PQclear(result);
>               return TCL_ERROR;
> --- 909,915 ----
>   
>           sprintf(oid_buf, "%u", PQoidValue(result));
>           if (Tcl_SetVar(interp, oid_varname, oid_buf,
> !                        TCL_LEAVE_ERR_MSG) == NULL)
>           {
>               PQclear(result);
>               return TCL_ERROR;
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
> 
> http://archives.postgresql.org
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026