Re: Bug #631: pg_dumpall does not accept -F or -f

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > Peter Eisentraut wrote:
> > > > The pg_dumpall script seems to ignore the file and format switches
> > > > that are used with pg_dump.  pg_dumpall always writes to stdout in
> > > > text format.  Also, the -b switch can not be used with pg_dumpall
> > > > since text output is being forced.
> > >
> > > That's not a bug.
> >
> > Peter, can you explain why to the user; it is not clear to me why
> > either, though I have my suspicions, and shouldn't we throw an error to
> > the user when they try it?
>
> The pg_dumpall reference page explicitly cautions against this situation.

I see that now:

       Any other command line parameters are passed to the under-
       lying pg_dump(1) calls. This is  useful  to  control  some
       aspects of the output format, but some options such as -f,
       -t, and dbname should be avoided.

However, it seems we should explicitly throw an error if someone tries
to use these flags.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026