Re: 7.2 fe-exec.c patch to PQescapeString()

I am not sure about this patch. If they pass NULL as string pointers,
but a positive length, I think we should crash rather than assuming
everything is OK.  The code already works OK for length = 0.  In fact,
the patch makes length=0 do nothing, rather than having it execute this
line:

    /* Write the terminating NUL character. */
    *target = '\0';

---------------------------------------------------------------------------

Ed Loehr wrote:
> This patch makes PQescapeString() guard against null input
>
> ptrs and/or length == 0 input.  If any of these occur, the
>
> function returns 0.
>

> *** fe-exec.c.orig    Thu Apr  4 16:06:38 2002
> --- fe-exec.c    Thu Apr  4 16:07:30 2002
> ***************
> *** 75,76 ****
> --- 75,80 ----
>
> +     if ( ! to || ! from || ! length ) {
> +         return 0;
> +     }
> +
>       while (remaining > 0)

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026