Re: quotes in SET grammar

Tom Lane wrote:
> Thomas Lockhart  writes:
> > Possible cases look like
> 
> >   SET TIME ZONE 'pst8pdt';
> >   SET TIME ZONE "pst8pdt";
> >   SET DATESTYLE = "US","ISO";
> 
> > Is there any objection to allowing both single- and double-quoted
> > strings in SET? Or should I remove the double-quoted variety altogether?
> 
> I think it would be best to disallow the double-quoted form.  If we
> allow it, then we will have a backwards-compatibility problem should
> we ever want to generalize SET to accept an expression (because
> double-quoted things are identifiers, not literals).
> 
> However, I'm not sure *how* to disallow it without also disallowing
> unquoted words (since ultimately the productions reduce to ColId,
> and the lexer output doesn't distinguish quoted and unquoted
> identifiers).  I don't think I want to go back to writing
> 	set whatever to 'on';
> so I guess I'll have to just grin and bear it.
> 
> I agree that all the forms of SET should be consistent about what
> kinds of quoted or unquoted words they will take.

I see, because we allow non-quoted values, the quotes are accepted too. 
Makes sense.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610) 853-3000 +  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026