Re: pg_ctl - tighten command parameter checking

Need to use case before patch application.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Oliver Elphick writes:
> 
> > The attached patch improves the command parameter checking of pg_ctl.
> >
> > At present, there is nothing to check that the parameter given with a
> > parameter-taking option is actually valid.  For example, -l can be given
> > without a following logfile name; on a strict POSIX shell such as ash,
> > you will get a subsequent failure because of too many shifts, but bash
> > will let it pass without showing any error.  The patch checks that each
> > parameter is not empty and is not another option.
> 
> Isn't this problem present in all of our scripts?
> 
> Btw., you shouldn't use "cut" in portable scripts.  You could probably use
> "case" to do the matching you want.
> 
> -- 
> Peter Eisentraut   peter_e@gmx.net
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026