Re: patch: INSERT INTO t VALUES (a, b, ..., DEFAULT, ...)

Can we get a context diff, diff -c for this?

---------------------------------------------------------------------------

Pavlo Baron wrote:
> here is a new patch containing all changes you (Tom) suggested to make. I
> still use my "pavlo (pbpbit.org)" for me to locate my code; feel free to
> illiminate them before integrating :-)
> 
> Tom Lane:
> > This would break
> > INSERT INTO foo(textcolumn) VALUES ('@default')
> > which I find hardly acceptable.
> >
> > The only way to do it without breaking valid data entries is to
> > introduce a new parse node type to represent a DEFAULT placeholder.
> 
> Now there is a newly declared parse node type "Default" - the corresponding
> structure has no data. The "@default" hack is now illiminated - I'm the
> happiest about it
> 
> Tom Lane:
> >
> > I also wonder what's going to happen if I write DEFAULT in a SELECT's
> > targetlist, which is possible given where you made the grammar change.
> 
> The grammer now contains two new rules: "insert_target_list" and
> "insert_target_el", the SELECT and INSERT don't use the same targetlist
> anymore, but the "insert_target_el" completely inherits "target_el" to avoid
> multiple declarations and  it just provides the new DEFAULT-rule.
> 
> I hope, this patch is ok - to me, it looks correct now
> 
> rgds
> Pavlo Baron
> 

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
> 
> http://www.postgresql.org/users-lounge/docs/faq.html

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026