Re: elog cleanup

Serguei Mokhov wrote:
> ----- Original Message -----
> From: "Bruce Momjian" <pgman@candle.pha.pa.us>
> Sent: Tuesday, February 19, 2002 12:16 AM
>
> ...
>
> > ! elog(CRASH, "heap_delete_%sdo: no block", (redo) ? "re" : "un");
> > ! elog(CRASH, "heap_delete_%sdo: uninitialized page", (redo) ? "re" : "un");
>
> ...
>
> This type of "dynamically constructed" messages is kinda bad for translators,
> because the parts one's replacing in the original message could be
> translated differently entirely and may not suit in the translations as they do in the originals.
> Even if they do, "re" and "un" will never make into the message catalogs, for example.
>
> Maybe it's not so crucial for these specific messages, but for sure won't
> work for general type of messages.

This is a good point.  I am not too concerned about this case because it
is attempting to match an actual function name.  I hope we don't do this
for more general messages.  My guess is that we don't, because if we
did, some translator would have complained.  :-)

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026