Re: ODBC changes
От | Bruce Momjian |
---|---|
Тема | Re: ODBC changes |
Дата | |
Msg-id | 200111280015.fAS0Fnh14679@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: ODBC changes (Hiroshi Inoue <Inoue@tpf.co.jp>) |
Список | pgsql-odbc |
> > I believe you are commenting about this in md5.h: > > > > #ifdef WIN32 > > #define MD5_ODBC > > #define FRONTEND > > #endif > > > > Yes, not sure this makes sense anymore because Hiroshi added win_md5.c > > which defines those and then includes md5.c. Hiroshi, should this part > > be removed? > > #define MD5_ODBC in md5.h is useless from the first > because md5.h isn't #included unless MD5_ODBC is #defined. > I don't know about FRONTEND. Usually I don't use win32.mak > to compile the driver. It seems Dave doesn't use it either. > The extra two -D(/D) compile options seem too heavy only > for md5.c, so I added win_md5.c to avoid my mistake. Note > that md5.c is used directly under *nixes. OK, I am applying the following patch. Instead of using -D in each compile script, Hiroshi has used win_md5.c to define what he needs and then include md5.c. With this method, the test in md5.h is no longer needed. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 Index: src/interfaces/odbc/md5.h =================================================================== RCS file: /cvsroot/pgsql/src/interfaces/odbc/md5.h,v retrieving revision 1.6 diff -c -r1.6 md5.h *** src/interfaces/odbc/md5.h 2001/11/19 06:26:00 1.6 --- src/interfaces/odbc/md5.h 2001/11/28 00:13:40 *************** *** 14,23 **** #include <stdlib.h> #include <string.h> - #ifdef WIN32 - #define MD5_ODBC - #define FRONTEND - #endif #define MD5_PASSWD_LEN 35 /* From c.h */ --- 14,19 ----
В списке pgsql-odbc по дате отправления: