Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)
От | Bruce Momjian |
---|---|
Тема | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) |
Дата | |
Msg-id | 200111151635.fAFGZic03096@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) ("Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at>) |
Ответы |
Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)
|
Список | pgsql-patches |
OK, I backed out your previous patch and applied this one. Thanks. --------------------------------------------------------------------------- > > > "Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at> writes: > > > > /* Plain "long int" fits, use it */ > > + #if SIZEOF_INT8 == 0 > > typedef long int int64; > > + #endif > > + #if SIZEOF_UINT8 == 0 > > typedef unsigned long int uint64; > > + #endif > > > > > > This coding appears to assume "if the platform defines int8, then > > it will define int64 as well". Seems mighty fragile to me. > > Well the absolute correct solution would involve all of: > int8, int16, int32, int64 and separately uint8, uint16, uint32, uint64 > > The previous patch grouped: > int8, int16 and int32 > uint8, uint16 and uint32 > int64 and uint64 <-- this grouping is wrong on AIX 4.3.3 and below > > If you prefer to make 4 groups out of this you could apply this patch. > > Andreas Content-Description: int8-newpatch2 [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
В списке pgsql-patches по дате отправления: