> John Gray <jgray@azuli.co.uk> writes:
> >> Some creative refactoring would help it out a lot. Go for it, if
> >> you feel like doing that.
> >>
> > I've done a little tidying, repackaging of standard code etc. as a first
> > step. It hasn't made the file much shorter, but has made some of the
> > routines clearer where they share basically the same code for
> > inheritance and permissions checking.
>
> Great! I'm afraid I just committed some fixes that will probably cause
> a merge conflict, but I trust it won't be too painful to resolve.
>
> > AS regards the ALTER TABLE ALTER COLUMN syntax for attstorage, should I
> > use keywords for the values or just char values 'e', 'x' etc ?
>
> I'd suggest keywords, namely the same ones used in CREATE TYPE for
> these storage options.
I assume this will be for 7.3?
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026