Re: More fixes for missing double quotes in the shell
От | Bruce Momjian |
---|---|
Тема | Re: More fixes for missing double quotes in the shell |
Дата | |
Msg-id | 200109300001.f8U01cH09255@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: More fixes for missing double quotes in the shell (Peter Eisentraut <peter_e@gmx.net>) |
Список | pgsql-patches |
> Justin writes: > > > I agree it's not strictly necessary, but I thought I'd add them in to > > follow the generic "good programming practise" of always quoting > > variables in shell script tests. > > In my purely personal opinion it's better to be aware of the possible > values of a variable than to blindly quote everything. Somewhere you're > going to run into nested quote situations which cannot be done portably, > at which point you have to start doing that anyway. I am not good at remembering what could be in a variabe. I find it easier to just quote everything. If I have embedded quotes, I do "\"$X\"". That requires fiddling less often than having values that need/don't need quote protection. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
В списке pgsql-patches по дате отправления: