Re: More fixes for missing double quotes in the shell scripts
От | Bruce Momjian |
---|---|
Тема | Re: More fixes for missing double quotes in the shell scripts |
Дата | |
Msg-id | 200109281928.f8SJSKP13298@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: More fixes for missing double quotes in the shell scripts (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-patches |
> Justin <justin@postgresql.org> writes: > > If there's really something fundamentally wrong with this idea, then > > let's only do the necessary ones. > > No, nothing fundamentally wrong. I just prefer to avoid unnecessary > notational clutter. Your approach of "let's quote *every* shell > variable" is defensible but I find it a tad over-the-top. Comes down > to a judgment call about code legibility, I suppose. I prefer the quoting all style, though $? is a special case, as is $#, and $$, which I certainly would not quote. Up to you guys. Also, I like that fact we are cleaning this up. From my days writing shql, I always thought quoting behavour should have been the default for environment variables. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
В списке pgsql-patches по дате отправления: